[chore] Fixed Bug: Examples rendering is broken in 1.26 release for array types #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-examples-jinja-macro
joaopgrassi
reviewed
May 29, 2024
lmolkova
approved these changes
May 29, 2024
trisch-me
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 1.26 release the markdown rendering of attribute examples is broken for array types.
An example for a
string[]attribute type should be displayed as an array:["a", "b"]. In 1.26 they are shown as multiple examples appropriate forstringtype:a;b.This bug is due to the change to the jinja templates now driven by weaver.
I have fixed the jinja template and run the markdown generation.
Merge requirement checklist
[chore]